-
Notifications
You must be signed in to change notification settings - Fork 25.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undeprecate function_score query #87807
Merged
mayya-sharipova
merged 1 commit into
elastic:master
from
mayya-sharipova:undrepecate-function-score
Jun 17, 2022
Merged
Undeprecate function_score query #87807
mayya-sharipova
merged 1 commit into
elastic:master
from
mayya-sharipova:undrepecate-function-score
Jun 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a plan to deprecate function_score query with script_score query, but ran into a roadblock of missing functionality to combine scores from different functions (particularly "first" script_score). Wee have several proposal to address this missing functionality: [scripted_boolean](elastic#27588 (comment)) [compound_query](elastic#51967) [first_query](elastic#52482) But for now, we decided not to deprecate function_score query, and hence we need to remove any mention that we are deprecating it. Relates to elastic#42811 Closes elastic#71934
Pinging @elastic/es-search (Team:Search) |
Pinging @elastic/es-docs (Team:Docs) |
javanna
approved these changes
Jun 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
mayya-sharipova
added a commit
that referenced
this pull request
Jun 17, 2022
We had a plan to deprecate function_score query with script_score query, but ran into a roadblock of missing functionality to combine scores from different functions (particularly "first" script_score). Wee have several proposal to address this missing functionality: [scripted_boolean](#27588 (comment)) [compound_query](#51967) [first_query](#52482) But for now, we decided not to deprecate function_score query, and hence we need to remove any mention that we are deprecating it. Relates to #42811 Closes #71934
mayya-sharipova
added a commit
that referenced
this pull request
Jun 17, 2022
We had a plan to deprecate function_score query with script_score query, but ran into a roadblock of missing functionality to combine scores from different functions (particularly "first" script_score). Wee have several proposal to address this missing functionality: [scripted_boolean](#27588 (comment)) [compound_query](#51967) [first_query](#52482) But for now, we decided not to deprecate function_score query, and hence we need to remove any mention that we are deprecating it. Relates to #42811 Closes #71934
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a plan to deprecate function_score query with
script_score query, but ran into a roadblock of missing
functionality to combine scores from different
functions (particularly "first" script_score).
Wee have several proposal to address this missing
functionality:
scripted_boolean
compound_query
first_query
But for now, we decided not to deprecate function_score query,
and hence we need to remove any mention that we are deprecating it.
Relates to #42811
Closes #71934